chore: prune some deps #119
Conversation
| @@ -24,12 +24,11 @@ hyper = { version = "0.14.16", features = ["full"], optional = true } | |||
| iroh-net = { version = "0.28.1", optional = true } | |||
| pin-project = "1" | |||
| quinn = { package = "iroh-quinn", version = "0.12", optional = true } | |||
| serde = { version = "1.0.183", features = ["derive"] } | |||
| serde = { version = "1.0", features = ["derive"] } | |||
There was a problem hiding this comment.
As a general note (which is going to be super hard to make actionable - apologies), you have to be somewhat careful when removing the .z part. SometimesOften they're needed for minimal crate versions to work.
However I appreciate that without such a check in CI it is extremely hard to know whether this version number was just added because it was just the default some tool did or whether that is actually a minimal version...
So... I guess this comment is rather unactionable as long as we don't have a minimal crates version CI check. 🙃
There was a problem hiding this comment.
Ohhh right, very good info!
There was a problem hiding this comment.
How do you find the minimal version that works? Bisect?
There was a problem hiding this comment.
Yeah... basically bissect. Because rust crates don't have changelogs. I did this manually in beetle, maybe there's a smarter way.
|
And here I was pulling out my hair while the minimal version was broken all along. I did move the needle forward a bit on it though. |
@rklaehn Should we work to bump hyper to 1.5?