Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(iroh-gossip): fix net smoke test #2314

Merged
merged 5 commits into from
May 21, 2024
Merged

tests(iroh-gossip): fix net smoke test #2314

merged 5 commits into from
May 21, 2024

Conversation

Frando
Copy link
Member

@Frando Frando commented May 21, 2024 •
edited
Loading

Description

  • Use shared test setup code from iroh_net
  • Fix stupid typo

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Frando Frando changed the title [wip] gossip: debugging net module fix(iroh-gossip): fix net smoke test May 21, 2024
@Frando Frando marked this pull request as ready for review May 21, 2024 13:24
@divagant-martian divagant-martian changed the title fix(iroh-gossip): fix net smoke test tests(iroh-gossip): fix net smoke test May 21, 2024
divagant-martian
divagant-martian approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what an annoying typo. LGTM

@divagant-martian divagant-martian added this to the v0.17.0 milestone May 21, 2024
@divagant-martian divagant-martian added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 8ad6ff1 May 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian approved these changes

Assignees

@Frando Frando

Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Frando @divagant-martian