refactor(iroh-sync): remove generic from SyncEngine #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Oct 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dignifiedquire
pushed a commit
that referenced
this pull request
Oct 18, 2023
## Description With #1612 we moved all operations on replicas into a dedicated actor, with all communication happening over a channel. A nice consequence of this is that the iroh-sync store only lives in the actor thread, and therefore we don't need a generic on the `SyncEngine` and the `Node` anymore. This PR removes the generic. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #1612 we moved all operations on replicas into a dedicated actor, with all communication happening over a channel. A nice consequence of this is that the iroh-sync store only lives in the actor thread, and therefore we don't need a generic on the
SyncEngineand theNodeanymore. This PR removes the generic.Change checklist