feat: leave and drop docs #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2023
Closed
|
I adjusted the naming to be Latest commit adds a high-level test and also makes sure that the event subscription streams are properly terminated for removed docs. |
|
Ok we decided to |
iroh/src/commands/sync.rs
Outdated
| Self::Drop { doc } => { | ||
| let doc = get_doc(iroh, env, doc).await?; | ||
| iroh.docs.drop_doc(doc.id()).await?; | ||
| println!("Doc {} has been removed.", fmt_short(doc.id())); |
There was a problem hiding this comment.
what about asking for confirmation?
|
Added a confirmation prompt. |
dignifiedquire
approved these changes
Oct 10, 2023
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description In `iroh-sync`: * feat: Add `Store::remove_replica` to remove a replica (namespace secret key and all entries) * feat: Adds `closed` atomic bool on `Replica` to ensure no operations can be performed on closed or removed replicas * refactor: To not add yet another `Arc` for the `closed` marker, move all things into `InnerReplica` In `iroh`: * feat: Add `DocDrop` to RPC protocol * rename `StopSync` to `Leave` * feat: Add `doc leave` command to CLI / console. `doc leave` runs `DocStopSync` in the RPC layer (we already had that), * feat: Add `doc drop` command to delete a document ## Notes & open questions Fixes #1497 ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
iroh-sync:Store::remove_replicato remove a replica (namespace secret key and all entries)closedatomic bool onReplicato ensure no operations can be performed on closed or removed replicasArcfor theclosedmarker, move all things intoInnerReplicaIn
iroh:DocDropto RPC protocolStopSynctoLeavedoc leavecommand to CLI / console.doc leaverunsDocStopSyncin the RPC layer (we already had that),doc dropcommand to delete a documentNotes & open questions
Fixes #1497
Change checklist