Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move iroh bytes get handlers out of node into module #1343

Merged
merged 3 commits into from
Aug 11, 2023
Merged

refactor: move iroh bytes get handlers out of node into module #1343

merged 3 commits into from
Aug 11, 2023

Conversation

Frando
Copy link
Member

@Frando Frando commented Aug 10, 2023 •
edited by divagant-martian
Loading

Description

This is extracted from #1333. To use the iroh-bytes get protocol easily from outside of the iroh::node::Node, these functions are moved into a new module get. They are used in the new Downloader in #1333.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

divagant-martian
divagant-martian approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@divagant-martian divagant-martian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of places where fmt bailed, but otherwise, I have verified this keeps the logic intact

iroh/src/get.rs Outdated Show resolved Hide resolved
iroh/src/get.rs Outdated Show resolved Hide resolved
iroh/src/get.rs Outdated Show resolved Hide resolved
iroh/src/get.rs Outdated Show resolved Hide resolved
iroh/src/get.rs Outdated Show resolved Hide resolved
@Frando Frando added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2023
@Frando Frando added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2023
@divagant-martian divagant-martian added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2023
@Arqu Arqu added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit ce4cb57 Aug 11, 2023
@b5 b5 added this to the v0.6.0 - Sync milestone Aug 16, 2023
@dignifiedquire dignifiedquire deleted the move-get-to-module branch November 1, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.6.0-alpha.0: Sync!
Development

Successfully merging this pull request may close these issues.
4 participants
@Frando @divagant-martian @b5 @Arqu