Add back the get --single functionality that has been lost during a refactoring #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both stdout and file output, but not resume
flub
approved these changes
Jun 5, 2023
|
wow, everything is green?!? |
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
…efactoring (#1070) * fix: add handling of --single parameter for stdout target * fix: add handling of --single parameter for dir target * test: add tests for --single paramter both stdout and file output, but not resume * fix: allow using Blake3Cid in tests even for the MSRV test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this should even be the same command. Maybe get blob or get-blob? But we have a bit of a feature explosion.
get (hash / ticket) x (collection / blob)
In any case, the single code path is now separate, which makes things simpler. One question I have is how much, if any, progress we should have when getting single or collection to stdout.
If you just get to stdout without redirecting, the stderr progress and stdout content get mixed and will look very confusing...