Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement metrics for netcheck #927

Closed
dignifiedquire opened this issue Apr 3, 2023 · 1 comment
Closed

implement metrics for netcheck #927

dignifiedquire opened this issue Apr 3, 2023 · 1 comment
Assignees
@flub
Labels
hole punching metrics extracting quantified mesurements from iroh
Milestone
v0.5.0 - Connecti...

Comments

@dignifiedquire
Copy link
Contributor

No description provided.

@dignifiedquire dignifiedquire added metrics extracting quantified mesurements from iroh hole punching labels Apr 3, 2023
@flub flub self-assigned this May 15, 2023
flub added a commit that referenced this issue May 24, 2023
@flub
metrics(netcheck): Add the basic netcheck metrics
10ee54c 
This adds the basic metrics to netcheck.  There's probably room for
more.

Also updates the macros to be a bit more ergonomic:

- Allow optional trailing comma on the last item in the metrics
  definition.

- When using metrics start a new scope for the compiler so that we can
  use it anywhere, e.g. also in match statements where the expression
  is followed with a , rather than a ;.

Closes #927
@flub flub mentioned this issue May 24, 2023
Merged
flub added a commit that referenced this issue May 25, 2023
@flub
metrics(netcheck): Add the basic netcheck metrics (#1048)
a548371 
This adds the basic metrics to netcheck.  There's probably room for
more.

Also updates the macros to be a bit more ergonomic:

- Allow optional trailing comma on the last item in the metrics
  definition.

- When using metrics start a new scope for the compiler so that we can
  use it anywhere, e.g. also in match statements where the expression
  is followed with a , rather than a ;.

Closes #927
@dignifiedquire
Copy link
Contributor Author

Done in #1048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flub flub

Labels
hole punching metrics extracting quantified mesurements from iroh
Projects
None yet
Milestone
v0.5.0 - Connectivity intensifies
Development

No branches or pull requests
2 participants
@flub @dignifiedquire