-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make creating a directory the default when asking for a collection with more than 1 element. #843
Comments
The default on the cli is that if you don't specify an Is this what you are running into? |
Yes. Nothing major, but I was playing around with ML datasets, and having a 300GB dataset being dumped on the CLI is definitely not what I was after. The terminal was so irritated by the amount of data and all the weird chars that I had to close the tab. Not a good user experience. |
I wonder if we should dumping to |
My 2c: |
Can we just say that you have to provide an out arg when downloading a collection? You can still have the simple curl use case when downloading individual files, which is supported now. So you can still do workflows involving individual files like the infamous But I find that wanting all items of a collection concatenated is rare even for smaller data sets. |
I think sth like |
So the default behaviour of share when not providing an out dir is to just download it to the local store. Which I think is fine, because it does not try to output a giant amount of data to the console. Maybe just discourage get in favour of share? |
When using `iroh get` always require `--out` to specify the place to store the output. ```sh # stdout > iroh get --ticket <TICKET> --out STDOUT # directory > iroh get --ticket <TICKET> --out ./my-dir ``` Closes #843
When using `iroh get` always require `--out` to specify the place to store the output. ```sh # stdout > iroh get --ticket <TICKET> --out STDOUT # directory > iroh get --ticket <TICKET> --out ./my-dir ``` Closes #843
If you currently get a directory, you will just get the concatenation of all files.
This is not what you want if you want to replicate a large directory.
Found this confusing when trying out sharing a large data set.
The text was updated successfully, but these errors were encountered: