Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol collisions when building with both iroh and ssi crates as dependencies #2217

Closed
cameronfyfe opened this issue Apr 20, 2024 · 4 comments · Fixed by n0-computer/iroh-blake3#5 or #2246
Closed

Symbol collisions when building with both iroh and ssi crates as dependencies #2217

cameronfyfe opened this issue Apr 20, 2024 · 4 comments · Fixed by n0-computer/iroh-blake3#5 or #2246
Assignees
@rklaehn
Milestone
v0.15.0

Comments

@cameronfyfe
Copy link
Contributor

When I build a project that use crates from /~https://github.com/spruceid/ssi that bring in their own blake3 crate I get symbol collision errors at link time on some platforms.

I haven't had issues on x86-linux or aarch64-macos but aarch64-linux builds fail due to the multiple blake3 libraries.

My work-around for now is that I forked iroh-blake3 and changed the package name back to blake3 which lets me do a cargo patch to override the blake3 crates brought in by the SSI crates. (cargo only lets you apply patches to crates with the same package name name).
@github-project-automation github-project-automation bot moved this to 📋 Backlog in iroh Apr 20, 2024
@cameronfyfe cameronfyfe changed the title Symbol collisions when building with both iroh and ssi crates as dependencies. Symbol collisions when building with both iroh and ssi crates as dependencies Apr 20, 2024
@flub flub mentioned this issue Apr 22, 2024
Merged
@flub
Copy link
Contributor

flub commented Apr 22, 2024

see n0-computer/iroh-blake3#5

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Apr 23, 2024
@flub
Copy link
Contributor

flub commented Apr 23, 2024

Guess this shouldn't be closed yet. This can only be closed once a new iroh-blake3 release is made and we use that in iroh.

@flub flub reopened this Apr 23, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📋 Backlog in iroh Apr 23, 2024
@flub flub moved this from 📋 Backlog to 🏗 In progress in iroh Apr 23, 2024
@flub flub added this to the v0.15.0 milestone Apr 23, 2024
@flub
Copy link
Contributor

flub commented Apr 23, 2024

I'm not able to push this any further. iroh-blake3 is owned by @rklaehn on crates.io so it's in his hands.

@flub flub assigned rklaehn and unassigned flub Apr 23, 2024
@dignifiedquire
Copy link
Contributor

iroh-blake3@1.4.5 fixes this

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Apr 26, 2024
flub added a commit that referenced this issue Apr 26, 2024
@flub
deps(iroh-blake3): Upgrade to version fixing more symbol collions
0bb3ad5 
We did get reports of the iroh-blake3 still having symbol collisions
with blake3.  Depend on the new version now.  Hopefully these were the
last of the symbol collisions.

Closes #2217
@flub flub mentioned this issue Apr 26, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue Apr 26, 2024
@flub
deps(iroh-blake3): Upgrade to version fixing more symbol collions (#2246
0c336c4 
)

## Description

We did get reports of the iroh-blake3 still having symbol collisions
with blake3.  Depend on the new version now.  Hopefully these were the
last of the symbol collisions.

Closes #2217

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~
matheus23 pushed a commit that referenced this issue Nov 14, 2024
@flub
deps(iroh-blake3): Upgrade to version fixing more symbol collions (#2246
7cfa19a 
)

## Description

We did get reports of the iroh-blake3 still having symbol collisions
with blake3.  Depend on the new version now.  Hopefully these were the
last of the symbol collisions.

Closes #2217

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rklaehn rklaehn

Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.15.0
4 participants
@flub @rklaehn @dignifiedquire @cameronfyfe