feat: leave and drop docs (#1589)

## Description

In `iroh-sync`:
* feat: Add `Store::remove_replica` to remove a replica (namespace
secret key and all entries)
* feat: Adds `closed` atomic bool on `Replica` to ensure no operations
can be performed on closed or removed replicas
* refactor: To not add yet another `Arc` for the `closed` marker, move
all things into `InnerReplica`

In `iroh`:
* feat: Add `DocDrop` to RPC protocol
* rename `StopSync` to `Leave`
* feat: Add `doc leave` command to CLI / console. `doc leave` runs
`DocStopSync` in the RPC layer (we already had that),
* feat: Add `doc drop` command to delete a document

## Notes & open questions

Fixes #1497 

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.

iroh-sync/src/keys.rs

@@ -221,13 +221,13 @@ impl fmt::Debug for Author {
 
 impl fmt::Debug for NamespacePublicKey {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(f, "NamespaceId({})", self)
+        write!(f, "NamespacePublicKey({})", self)
     }
 }
 
 impl fmt::Debug for AuthorPublicKey {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(f, "AuthorId({})", self)
+        write!(f, "AuthorPublicKey({})", self)
     }
 }
 
@@ -410,7 +410,7 @@ impl AuthorId {
     /// Convert into [`AuthorPublicKey`].
     ///
     /// Fails if the bytes of this [`AuthorId`] are not a valid [`ed25519_dalek`] curve point.
-    pub fn into_public_key<S: PublicKeyStore>(&self) -> Result<AuthorPublicKey, SignatureError> {
+    pub fn into_public_key(&self) -> Result<AuthorPublicKey, SignatureError> {
         AuthorPublicKey::from_bytes(&self.0)
     }
 }
@@ -439,7 +439,7 @@ impl NamespaceId {
     /// Convert into [`NamespacePublicKey`].
     ///
     /// Fails if the bytes of this [`NamespaceId`] are not a valid [`ed25519_dalek`] curve point.
-    pub fn into_public_key<S: PublicKeyStore>(&self) -> Result<NamespacePublicKey, SignatureError> {
+    pub fn into_public_key(&self) -> Result<NamespacePublicKey, SignatureError> {
         NamespacePublicKey::from_bytes(&self.0)
     }
 }

iroh-sync/src/store.rs

@@ -75,6 +75,12 @@ pub trait Store: std::fmt::Debug + Clone + Send + Sync + 'static {
     /// instance from the store's cache.
     fn close_replica(&self, namespace: &NamespaceId);
 
+    /// Remove a replica.
+    ///
+    /// Completely removes a replica and deletes both the namespace private key and all document
+    /// entries.
+    fn remove_replica(&self, namespace: &NamespaceId) -> Result<()>;
+
     /// Create a new author key and persist it in the store.
     fn new_author<R: CryptoRngCore + ?Sized>(&self, rng: &mut R) -> Result<Author> {
         let author = Author::new(rng);

iroh-sync/src/store/fs.rs

@@ -147,7 +147,7 @@ impl super::Store for Store {
 
     fn close_replica(&self, namespace_id: &NamespaceId) {
         if let Some(replica) = self.replicas.write().remove(namespace_id) {
-            replica.unsubscribe();
+            replica.close();
         }
     }
 
@@ -206,6 +206,22 @@ impl super::Store for Store {
         Ok(replica)
     }
 
+    fn remove_replica(&self, namespace: &NamespaceId) -> Result<()> {
+        self.close_replica(namespace);
+        self.replicas.write().remove(namespace);
+        let start = range_start(namespace);
+        let end = range_end(namespace);
+        let write_tx = self.db.begin_write()?;
+        {
+            let mut record_table = write_tx.open_table(RECORDS_TABLE)?;
+            record_table.drain(start..=end)?;
+            let mut namespace_table = write_tx.open_table(NAMESPACES_TABLE)?;
+            namespace_table.remove(namespace.as_bytes())?;
+        }
+        write_tx.commit()?;
+        Ok(())
+    }
+
     fn get_many(
         &self,
         namespace: NamespaceId,
@@ -547,7 +563,7 @@ impl crate::ranger::Store<SignedEntry> for StoreInstance {
                 // iterator for all entries in replica
                 let iter = RangeIterator::with_range(
                     &self.store.db,
-                    |table| table.range(start..end),
+                    |table| table.range(start..=end),
                     RangeFilter::None,
                 )?;
                 // empty iterator, returns nothing
@@ -583,7 +599,7 @@ impl crate::ranger::Store<SignedEntry> for StoreInstance {
                 // iterator for entries from range.x to end
                 let iter2 = RangeIterator::with_range(
                     &self.store.db,
-                    |table| table.range(start..end),
+                    |table| table.range(start..=end),
                     RangeFilter::None,
                 )?;
                 iter.chain(iter2)

iroh-sync/src/store/memory.rs

@@ -53,7 +53,7 @@ impl super::Store for Store {
 
     fn close_replica(&self, namespace_id: &NamespaceId) {
         if let Some(replica) = self.replicas.read().get(namespace_id) {
-            replica.unsubscribe();
+            replica.close();
         }
     }
 
@@ -100,6 +100,13 @@ impl super::Store for Store {
         Ok(replica)
     }
 
+    fn remove_replica(&self, namespace: &NamespaceId) -> Result<()> {
+        self.close_replica(namespace);
+        self.replicas.write().remove(namespace);
+        self.replica_records.write().remove(namespace);
+        Ok(())
+    }
+
     fn get_many(
         &self,
         namespace: NamespaceId,