Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search component #31

Merged
merged 11 commits into from
May 29, 2020
Merged

Search component #31

merged 11 commits into from
May 29, 2020

Conversation

mxdi9i7
Copy link
Owner

@mxdi9i7 mxdi9i7 commented May 28, 2020

No description provided.

@TobbbbyZhao
Copy link
Collaborator

dude conflict

maxLength,
placeholder,
clearable = true,
autofocus,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does autofocus do?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you refresh the page, it will automatically focus on the input, you can type directly without having to mouse click the input

@TobbbbyZhao
Copy link
Collaborator

TobbbbyZhao commented May 29, 2020

Screen Shot 2020-05-28 at 8 14 47 PM
not equal margin, before the clear button

Copy link
Collaborator

@LIUSHANYIN LIUSHANYIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trista8130
Copy link
Collaborator

Screen Shot 2020-05-28 at 8 23 03 PM
I think when we click [cancel], input value should be clear.

@mxdi9i7
Copy link
Owner Author

mxdi9i7 commented May 29, 2020

Screen Shot 2020-05-28 at 8 23 03 PM
I think when we click [cancel], input value should be clear.

It's an action button, the clear functionality is limited to the clear icon only

@mxdi9i7 mxdi9i7 merged commit 0afbacc into master May 29, 2020
@mxdi9i7 mxdi9i7 deleted the peterz/search branch May 29, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants