Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ytdl-core to 4.15.9 and use new playerClients default #1197

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

enigodupont
Copy link
Contributor

This update will correct the readme for machine installs as I found the opus dependency only supports v18 and 19 of node.

I also updated the ytdl package to get upstream fixes for playback issues.

I also removed the playerClients override as it works with the defaults now.

I tested this with queries and a direct link for youtube.

@codetheweb
Copy link
Collaborator

codetheweb commented Jan 25, 2025

📦 🤖 A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1197.

Images are available for x86_64 and ARM64.

Latest commit: 39fe313

@enigodupont
Copy link
Contributor Author

I'm having trouble getting this to work on a windows install. works fine on a docker container.

@enigodupont
Copy link
Contributor Author

After updating fluent-ffmpeg to latest windows became stable.

Docker also continue to work as normal.

@shiftybitshiftr
Copy link
Contributor

Looks good! Ready to ship it?

@enigodupont
Copy link
Contributor Author

Yeah, if it's working for you I'm happy with it as is.

@kettui
Copy link

kettui commented Jan 25, 2025

Just a heads-up, might want to remove the package-lock.json from this PR before merging

package.json Outdated
@@ -85,11 +85,12 @@
}
},
"dependencies": {
"18": "^0.0.0",
Copy link

@kettui kettui Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an accidental addition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking now, I think it was added when I did a local install.

I'll remove and test it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, tested, and corrected my commit. Nice catch.

@shiftybitshiftr
Copy link
Contributor

Working with Docker on Alpine LXC. Merging.

@shiftybitshiftr shiftybitshiftr merged commit 92f63e0 into museofficial:master Jan 25, 2025
4 checks passed
@Cosmo121
Copy link

Works great! Docker on Rocky

JoeWHoward added a commit that referenced this pull request Jan 27, 2025
@codetheweb
Copy link
Collaborator

🚀 Released in Release v2.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants