-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ytdl-core to 4.15.9 and use new playerClients default #1197
Conversation
📦 🤖 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
I'm having trouble getting this to work on a windows install. works fine on a docker container. |
After updating fluent-ffmpeg to latest windows became stable. Docker also continue to work as normal. |
Looks good! Ready to ship it? |
Yeah, if it's working for you I'm happy with it as is. |
Just a heads-up, might want to remove the package-lock.json from this PR before merging |
package.json
Outdated
@@ -85,11 +85,12 @@ | |||
} | |||
}, | |||
"dependencies": { | |||
"18": "^0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an accidental addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking now, I think it was added when I did a local install.
I'll remove and test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, tested, and corrected my commit. Nice catch.
amend: Fixing packages
Working with Docker on Alpine LXC. Merging. |
Works great! Docker on Rocky |
🚀 Released in Release v2.10.1. |
This update will correct the readme for machine installs as I found the opus dependency only supports v18 and 19 of node.
I also updated the ytdl package to get upstream fixes for playback issues.
I also removed the playerClients override as it works with the defaults now.
I tested this with queries and a direct link for youtube.