-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset playerclients for ytdl during getinfo to defaults #1189
Conversation
📦 🤖 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
I am seeing this occasionally appear for some links. After many retries or trying other links the song will play again.
|
Update ytdl-core and ytsr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested with Docker on Alpine LXC and it's working without issues.
Started getting |
Sounds good, the following error is actually catching an existing error which was just an undefined access error. It existed before my changes, but my changed made it more visible.
Happy to look into build errors. |
You're right, I was conflating a net new issue (with bot playback) with the errors generated by this PR. My bad! |
Reset playerclients for ytdl during getinfo to defaults
🚀 Released in Release v2.10.1. |
Related to, #1180
Set the playerClients to values that worked before ytdl changed the defaults.
Should fix errors in playback.