Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset playerclients for ytdl during getinfo to defaults #1189

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

enigodupont
Copy link
Contributor

Related to, #1180

Set the playerClients to values that worked before ytdl changed the defaults.

Should fix errors in playback.

@codetheweb
Copy link
Collaborator

codetheweb commented Jan 20, 2025

📦 🤖 A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1189.

Images are available for x86_64 and ARM64.

Latest commit: 52d58af

@enigodupont
Copy link
Contributor Author

enigodupont commented Jan 20, 2025

I am seeing this occasionally appear for some links. After many retries or trying other links the song will play again.

ope: Cannot read properties of undefined (reading 'isLive')

Copy link
Contributor

@shiftybitshiftr shiftybitshiftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with Docker on Alpine LXC and it's working without issues.

@shiftybitshiftr shiftybitshiftr merged commit b10650b into museofficial:master Jan 22, 2025
4 checks passed
@shiftybitshiftr
Copy link
Contributor

Started getting 🚫 ope: Can't find suitable format. and build errors, reverting for now.

@enigodupont
Copy link
Contributor Author

Sounds good, the following error is actually catching an existing error which was just an undefined access error. It existed before my changes, but my changed made it more visible.

🚫 ope: Can't find suitable format.

Happy to look into build errors.

@shiftybitshiftr
Copy link
Contributor

shiftybitshiftr commented Jan 22, 2025

You're right, I was conflating a net new issue (with bot playback) with the errors generated by this PR. My bad!
Also, I realized the build errors were on my end for an unrelated problem.

shiftybitshiftr added a commit that referenced this pull request Jan 22, 2025
Reset playerclients for ytdl during getinfo to defaults
@codetheweb
Copy link
Collaborator

🚀 Released in Release v2.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants