Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN-16386] Fix parsing of MultiTransfer Event #6692

Merged

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Dec 27, 2024

Reasoning behind the pull request

  • Fix problem-related with missing tokens from accountsesdts index
  • This fix is needed because the MultiTransfer log events are not parsed correctly for native EGLD transfers

Proposed changes

  • Fixed how log event is parsed

Testing procedure

  • Ensure balance changes both for EGLD and ESDT are indexer correctly in accounts and accountsesdt index

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@miiu96 miiu96 changed the base branch from master to rc/spica-patch-relayedv3 December 27, 2024 11:37
@miiu96 miiu96 self-assigned this Dec 27, 2024
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@sstanculeanu
Copy link
Collaborator

sstanculeanu commented Jan 8, 2025

Run Tests:
mx-chain-testing-suite: main

@multiversx multiversx deleted a comment from github-actions bot Jan 8, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 8, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 8, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 175fcc36e1fb9af0e5b09ed1fea673fc36f2b177
  • Current Branch: MX-16386-bug-fix-missing-tokens-from-es
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-simulator-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 08012025-122441
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.8.6-dev-config-54bce4bb3a -> MX-16386-bug-fix-missing-t-175fcc36e1

--- Specific errors ---

block hash does not match 1840
wrong nonce in block 938
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 547
Nr. of new ERRORS: 0
Nr. of new WARNS: 13
Nr. of PANICS: 0
Nodes with panic: []

/------/

--- System test go ---

  • ✔️ basicMoveBalance scenario completed
  • ✔️ deployAndSCCall scenario completed
  • ✔️ deployAndSCCallBadSc - fund wallet, deploy a bad smart contract then do a SC call that usually takes a long time scenario completed
  • ✔️ deployAndSCCallSecurity - fund wallet, deploy a bad smart contract then do a SC call that usually takes a long time scenario completed
  • ✔️ esdtIssueTransfer scenario completed
  • ✔️ relayedTransactionsV1 scenario completed
  • ✔️ relayedTransactionsV2 scenario completed
  • ✔️ asyncLegacy scenario completed
  • ✔️ asyncMulti scenario completed
  • ✔️ asyncMultiCrossShard scenario completed
  • ✔️ asyncMultiTransferCrossShard scenario completed
  • ✔️ asyncEsdtTransfer - an async promises call with shard esdt transfer scenario completed
  • ✔️ asyncEsdtTransferCross - an async promises call with cross shard esdt transfer scenario completed%
    /------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@sstanculeanu sstanculeanu merged commit 5ebab05 into rc/spica-patch-relayedv3 Jan 9, 2025
8 checks passed
@sstanculeanu sstanculeanu deleted the MX-16386-bug-fix-missing-tokens-from-es branch January 9, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants