Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keygen workflow remove pull request action trigger #6410

Merged

Conversation

danidrasovean
Copy link
Collaborator

@danidrasovean danidrasovean commented Aug 26, 2024

Reasoning behind the pull request

  • Building the Docker image for keygenerator on each pull request is not necessary.

Proposed changes

  • Removed the pull request trigger from the GitHub Actions workflow, leaving only the manual workflow_dispatch trigger active.

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@danidrasovean danidrasovean self-assigned this Aug 26, 2024
@danidrasovean danidrasovean marked this pull request as ready for review August 26, 2024 12:12
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: aa637404027f90235b07253691372c9cad644c63
  • Current Branch: keygen-remove-pull-request-action-trigger
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 26082024-122117
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@danidrasovean danidrasovean merged commit 5b5fd3c into rc/v1.7.next1 Aug 26, 2024
11 checks passed
@danidrasovean danidrasovean deleted the keygen-remove-pull-request-action-trigger branch August 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants