Persister tmp file path #5995
Merged
Persister tmp file path #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/refactor-persister-factory #5995 +/- ##
===================================================================
- Coverage 80.37% 80.37% -0.01%
===================================================================
Files 709 709
Lines 94013 94000 -13
===================================================================
- Hits 75566 75553 -13
Misses 13161 13161
Partials 5286 5286 ☔ View full report in Codecov by Sentry. |
storage/factory/persisterCreator.go
Outdated
| @@ -49,25 +51,33 @@ func (pc *persisterCreator) Create(path string) (storage.Persister, error) { | |||
| return database.NewShardedPersister(path, pc, shardIDProvider) | |||
| } | |||
|
|
|||
| func getTmpFilePath(path string, pathSeparator string) (string, error) { | |||
| pathItems := strings.Split(path, pathSeparator) | |||
There was a problem hiding this comment.
instead of using the pathSeparator const, can we make use of the path package? Maybe path.Split can help?
There was a problem hiding this comment.
right, used path package, thanks
iulianpascalau
approved these changes
Feb 28, 2024
raduchis
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
UseTmpAsFilePathdb config field for all persistersTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?