Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc/v1.7.0 in feat/esdt improvements 30jan #5892

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

AdoAdoAdo and others added 30 commits November 3, 2023 13:50
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	common/constants.go
#	common/enablers/enableEpochsHandler.go
#	common/enablers/enableEpochsHandler_test.go
#	config/epochConfig.go
#	config/tomlConfig_test.go
Fixed dbConfigHandler to accommodate different DB configs
BeniaminDrasovean and others added 23 commits January 19, 2024 15:15
…h-2-2023.01.17

Update master rc sirius patch 2 2023.01.17
Fixed wrong multikey backup machine step-in
…-2024.01.29

# Conflicts:
#	common/enablers/enableEpochsHandler.go
#	common/enablers/enableEpochsHandler_test.go
#	common/enablers/epochFlags.go
#	common/interface.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	integrationTests/state/stateTrie/stateTrie_test.go
#	sharding/mock/enableEpochsHandlerMock.go
#	state/accountsDB_test.go
#	storage/factory/dbConfigHandler.go
#	storage/factory/dbConfigHandler_test.go
#	storage/factory/export_test.go
#	testscommon/enableEpochsHandlerMock/enableEpochsHandlerStub.go
#	trie/patriciaMerkleTrie_test.go
…7.0-2024.01.29

Merge rc sirius fixes rc v1.7.0 2024.01.29
…in-feat/esdt-improvements-30jan

# Conflicts:
#	common/constants.go
#	common/enablers/enableEpochsHandler.go
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	vm/systemSmartContracts/esdt.go
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (f0669bc) 80.41% compared to head (85ab6b8) 80.36%.

Files Patch % Lines
consensus/spos/bls/subroundEndRound.go 72.72% 2 Missing and 1 partial ⚠️
factory/processing/processComponents.go 66.66% 1 Missing and 1 partial ⚠️
factory/processing/processComponentsHandler.go 75.00% 1 Missing and 1 partial ⚠️
process/block/baseProcess.go 80.00% 1 Missing and 1 partial ⚠️
process/block/metablock.go 66.66% 1 Missing and 1 partial ⚠️
process/block/preprocess/transactions.go 33.33% 2 Missing ⚠️
state/trackableDataTrie/trackableDataTrie.go 50.00% 1 Missing and 1 partial ⚠️
storage/factory/storageServiceFactory.go 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/esdt-improvements    #5892      +/-   ##
==========================================================
- Coverage                   80.41%   80.36%   -0.06%     
==========================================================
  Files                         709      710       +1     
  Lines                       94353    94310      -43     
==========================================================
- Hits                        75874    75792      -82     
- Misses                      13174    13224      +50     
+ Partials                     5305     5294      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau self-requested a review January 30, 2024 12:47
@BeniaminDrasovean BeniaminDrasovean merged commit d24b625 into feat/esdt-improvements Jan 30, 2024
7 of 8 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the merge-rc/v1.7.0-in-feat/esdt-improvements-30jan branch January 30, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants