Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Support getRowId in row reordering #5093

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[data grid] Support getRowId in row reordering #5093

merged 1 commit into from
Jun 2, 2022

Conversation

flaviendelangle
Copy link
Member

Fixes #5092

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jun 2, 2022
@flaviendelangle flaviendelangle requested a review from DanailH June 2, 2022 09:03
@flaviendelangle flaviendelangle self-assigned this Jun 2, 2022
@mui-bot
Copy link

mui-bot commented Jun 2, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 262.1 417 346.5 336.3 61.533
Sort 100k rows ms 486.5 829.2 790.5 741.84 128.791
Select 100k rows ms 163.5 218.9 190.1 190.98 19.55
Deselect 100k rows ms 128.1 230.2 182.6 177.04 38.318

Generated by 🚫 dangerJS against 5522b66

@flaviendelangle flaviendelangle changed the title [data grid] Support getRowId in row reordering [data grid] Support getRowId in row reordering Jun 2, 2022
DanailH
DanailH approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@DanailH DanailH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@flaviendelangle flaviendelangle merged commit 7a97c95 into mui:master Jun 2, 2022
@flaviendelangle flaviendelangle deleted the row-reorder-id branch June 2, 2022 09:47
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022
@flaviendelangle @joserodolfofreitas
[data grid] Support getRowId in row reordering (mui#5093)
3b8f16a
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[data grid] Support getRowId in row reordering (mui#5093)
5d51273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Rows reordering doesn't work when using getRowId
3 participants
@flaviendelangle @mui-bot @DanailH