Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Add an id to the filter item created when opening the filter panel #5014

Merged
merged 1 commit into from
May 30, 2022
Merged

[data grid] Add an id to the filter item created when opening the filter panel #5014

merged 1 commit into from
May 30, 2022

Conversation

flaviendelangle
Copy link
Member

Fixes #4943

I also added it to the single filtering to handle switch between single and multi filtering (even if it's a very marginal use case)

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels May 25, 2022
@flaviendelangle flaviendelangle self-assigned this May 25, 2022
@mui-bot
Copy link

mui-bot commented May 25, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 253.6 463.2 322 346.32 81.331
Sort 100k rows ms 551.6 946.6 710.2 756.82 141.957
Select 100k rows ms 131.5 249.5 188.3 183.84 39.033
Deselect 100k rows ms 117.4 209.2 145.7 162.64 39.016

Generated by 🚫 dangerJS against 3fab8ab

@cherniavskii
Copy link
Member

Before: https://codesandbox.io/s/basicexampledatagridpro-material-demo-forked-b4xh84
After: https://codesandbox.io/s/basicexampledatagridpro-material-demo-forked-vd6uvv

@flaviendelangle flaviendelangle merged commit c15d12b into mui:master May 30, 2022
@flaviendelangle flaviendelangle deleted the filter-id branch May 30, 2022 13:56
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[data grid] Add an id to the filter item created when opening the fil…
60ecf1d 
…ter panel (mui#5014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Filter item created when opening filter panel through a column menu does not contain and id
3 participants
@flaviendelangle @mui-bot @cherniavskii