Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve the workflow for incomplete issues #5012

Merged
merged 1 commit into from
May 25, 2022
Merged

[core] Improve the workflow for incomplete issues #5012

merged 1 commit into from
May 25, 2022

Conversation

mnajdova
Copy link
Member

@mui-bot
Copy link

mui-bot commented May 25, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 249.8 425.2 395.8 350.98 76.511
Sort 100k rows ms 429.7 871 662.8 656.74 140.708
Select 100k rows ms 120.6 291.4 189.7 195.98 65.661
Deselect 100k rows ms 99.5 294.2 146.6 156.38 71.135

Generated by 🚫 dangerJS against ddc2d9f

@mnajdova mnajdova requested a review from a team May 25, 2022 11:22
cherniavskii
cherniavskii approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mnajdova!

.github/workflows/no-response.yml
# Number of days of inactivity before an Issue is closed for lack of response
daysUntilClose: 7
# Label requiring a response
responseRequiredLabel: 'status: needs more information'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename status: incomplete to status: needs more information before merging this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the core I merged the PR and renamed the label right afterwards. Feel free to merge and update whenever you see fit. Here is a link to the current label - /~https://github.com/mui/mui-x/labels?q=incomplete

@mnajdova mnajdova added the core Infrastructure work going on behind the scenes label May 25, 2022
@cherniavskii cherniavskii merged commit 8bc1c94 into mui:master May 25, 2022
@oliviertassinari
Copy link
Member

I'm renaming the label to status: needs more information for the other repositories too :).

alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@mnajdova @alexfauquette
[core] Improve the workflow for incomplete issues (mui#5012)
dbc90a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@DanailH DanailH DanailH approved these changes

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mnajdova @mui-bot @oliviertassinari @flaviendelangle @DanailH @cherniavskii