[test] Skip Safari and Firefox on broken tests #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
oliviertassinari
changed the title
Comment on lines
198
to
200
| if (/safari/i.test(window.navigator.userAgent) || /firefox/i.test(window.navigator.userAgent)) { | ||
| this.skip(); | ||
| } |
There was a problem hiding this comment.
For each test, could we leave a comment on what's missing to make it work? I believe we have done this systematically in the past.
For instance:
Suggested change
| if (/safari/i.test(window.navigator.userAgent) || /firefox/i.test(window.navigator.userAgent)) { | |
| this.skip(); | |
| } | |
| // Only run in supported browsers | |
| if (typeof Touch === 'undefined') { | |
| this.skip(); | |
| } |
There was a problem hiding this comment.
👍 Sounds easier to read
There was a problem hiding this comment.
And more reliable, if tomorrow the API is available, then the test starts running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #4645 (comment)
Skip tests on Firefox and Safari because they fail without apparent reason