Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use new cache api for the row grouping last model tracking #4980

Merged
merged 3 commits into from
May 24, 2022
Merged

[core] Use new cache api for the row grouping last model tracking #4980

merged 3 commits into from
May 24, 2022

Conversation

flaviendelangle
Copy link
Member

No description provided.

@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! feature: Row grouping Related to the data grid Row grouping feature labels May 23, 2022
@flaviendelangle flaviendelangle requested a review from m4theushw May 23, 2022 13:38
@flaviendelangle flaviendelangle self-assigned this May 23, 2022
@mui-bot
Copy link

mui-bot commented May 23, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 290.3 685.6 397.1 436.54 135.141
Sort 100k rows ms 473.6 996.8 835.3 784.76 182.713
Select 100k rows ms 185.3 374.9 189.8 230.72 72.956
Deselect 100k rows ms 116 223.7 195.9 182.18 39.292

Generated by 🚫 dangerJS against ced44e4

@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label May 23, 2022
@flaviendelangle flaviendelangle merged commit b6bdb23 into mui:master May 24, 2022
@flaviendelangle flaviendelangle deleted the row-grouping-cache branch May 24, 2022 07:54
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[core] Use new cache api for the row grouping last model tracking (mu…
47d8c7d 
…i#4980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

@flaviendelangle flaviendelangle

Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes feature: Row grouping Related to the data grid Row grouping feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @m4theushw