Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Allow to scroll detail panel content if it overflows the panel #4979

Merged
merged 1 commit into from
May 24, 2022
Merged

[DataGridPro] Allow to scroll detail panel content if it overflows the panel #4979

merged 1 commit into from
May 24, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented May 23, 2022 •
edited
Loading

Low-hanging fruit extracted from #4955 (comment)

If detail panel content needs more space than provided by getDetailPanelHeight - it makes more sense to scroll instead of overflow

Before: https://codesandbox.io/s/basicdetailpanels-material-demo-forked-g8zynr
After: https://codesandbox.io/s/basicdetailpanels-material-demo-forked-pbqh6l

@mui-bot
Copy link

mui-bot commented May 23, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 252 586.6 393.8 402.78 122.756
Sort 100k rows ms 433.6 799.1 697.5 660.48 132.276
Select 100k rows ms 119.3 257.8 188.6 196.94 53.812
Deselect 100k rows ms 101.1 186.8 146.5 147.96 31.285

Generated by 🚫 dangerJS against d34564e

@cherniavskii cherniavskii changed the title [DataGridPro] Scroll detail panel content if it overflows the panel [DataGridPro] Allow to scroll detail panel content if it overflows the panel May 23, 2022
@cherniavskii cherniavskii requested a review from m4theushw May 23, 2022 13:10
m4theushw
m4theushw approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cherniavskii cherniavskii merged commit 4d967cc into mui:master May 24, 2022
@cherniavskii cherniavskii deleted the scroll-detail-panel-content branch May 24, 2022 10:14
@m4theushw m4theushw mentioned this pull request May 24, 2022
Closed
2 tasks
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@cherniavskii @alexfauquette
[DataGridPro] Allow to scroll detail panel content if it overflows th…
d09d05a 
…e panel (mui#4979)
@zannager zannager added component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherniavskii @mui-bot @m4theushw @zannager