Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix React 18 peer dependency #4908

Merged
merged 1 commit into from
May 18, 2022
Merged

[core] Fix React 18 peer dependency #4908

merged 1 commit into from
May 18, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 16, 2022 •
edited
Loading

Screenshot 2022-05-16 at 22 34 04

oliviertassinari
oliviertassinari commented May 16, 2022
View reviewed changes
packages/grid/x-data-grid-premium/package.json
@@ -55,7 +55,7 @@
"@mui/material": "^5.2.8",
"@mui/system": "^5.2.8",
"exceljs": "^4.3.0",
"react": "^17.0.2"
"react": "^17.0.2 || ^18.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I wanted to change

@mui-bot
Copy link

mui-bot commented May 16, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 248.7 587.4 365.8 376.16 126.546
Sort 100k rows ms 451.3 812.3 635.7 659.32 129.504
Select 100k rows ms 109.1 178.8 154.3 149.72 24.532
Deselect 100k rows ms 104.8 310.9 206.8 191.38 76.499

Generated by 🚫 dangerJS against c44c91d

oliviertassinari
oliviertassinari commented May 18, 2022
View reviewed changes
packages/x-date-pickers/package.json
@@ -64,8 +64,7 @@
"dayjs": "^1.10.7",
"luxon": "^1.28.0 || ^2.0.0",
"moment": "^2.29.1",
"react": "^17.0.2 || ^18.0.0",
"react-dom": "^17.0.2 || ^18.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never import from "react-dom" so I assume we don't need it.

@oliviertassinari oliviertassinari merged commit 3f9bc69 into mui:master May 18, 2022
@oliviertassinari oliviertassinari deleted the fix-peer-dependencies branch May 18, 2022 09:01
@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes plan: Premium Impact at least one Premium user labels May 18, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@oliviertassinari @alexfauquette
[core] Fix React 18 peer dependency (mui#4908)
bef90d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes plan: Premium Impact at least one Premium user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @m4theushw