-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix docs feedback widget not working #4905
Conversation
These are the results for the performance tests:
|
23e889d
to
07742a2
Compare
docs/.env
Outdated
@@ -0,0 +1 @@ | |||
FEEDBACK_URL=https://hgvi836wi8.execute-api.us-east-1.amazonaws.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be an environment variable set by Netlify.
@oliviertassinari @mbrookes Is there a reason that forces to use docs/.env
instead of an envvar? I didn't find any comment considering this option in mui/material-ui#22885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall any specific reason, so probably just an implementation issue. I do remember that I found other issues (unrelated to this), but the record of those is lost in a Slack comment (I should really have opened a GitHub issue), and I haven't looked at it since. It certainly isn't perfect, so feel free to improve it in whatever way you see fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move it to Netlify environment then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Form my perspective, MUI X shouldn't have to do anything to benefit from this feature, it should be fully isolated in the main repository, so no env variables. I'm adding this note to: https://www.notion.so/mui-org/Docs-page-feedback-rating-58166afbb53649c9ab873e646a637c8a#1a2cf3e6196d4b218b67169f811e280a
07742a2
to
ac8f9ba
Compare
I've noticed that feedback widget on MUI X docs website doesn't work:
The reason is missing
FEEDBACK_URL
was missing in MUI X env.Preview: https://deploy-preview-4905--material-ui-x.netlify.app/x/advanced-components/