Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] LICENSE max 80 char per line #4873

Merged
merged 1 commit into from
May 16, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 14, 2022

We are not respecting the 80 chars per line rule on our commercial license file. This leads to a scrollbar in https://unpkg.com/browse/@mui/x-license-pro@5.11.0/LICENSE, I have to scroll horizontally to read everything. It's annoying.

Screenshot 2022-05-15 at 02 31 36

Compare it to the MIT license: https://unpkg.com/browse/@mui/x-data-grid@5.11.0/LICENSE.

With this fix it feels like this 😌:
Screenshot 2022-05-15 at 00 57 37

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label May 14, 2022
@mui-bot
Copy link

mui-bot commented May 14, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 242 440.4 370.2 337.96 78.652
Sort 100k rows ms 472.7 816.4 616.6 651.3 130.435
Select 100k rows ms 124 259 185.3 180.96 47.773
Deselect 100k rows ms 98.6 148.2 143.7 131.3 17.528

Generated by 🚫 dangerJS against 5d67e34

@oliviertassinari oliviertassinari merged commit 747199e into mui:master May 16, 2022
@oliviertassinari oliviertassinari deleted the fix-license-scrollbar branch May 16, 2022 13:05
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants