Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Add class slots for toolbar components #4855

Merged
merged 1 commit into from
May 16, 2022
Merged

[pickers] Add class slots for toolbar components #4855

merged 1 commit into from
May 16, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 12, 2022 •
edited
Loading

Part of #4669

@m4theushw I am not very familiar yet with the slots so I may have done things wrong.
For instance, I removed the penIconClassName in favor of classes inside PickersToolbar.

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label May 12, 2022
@flaviendelangle flaviendelangle requested a review from m4theushw May 12, 2022 10:04
@flaviendelangle flaviendelangle self-assigned this May 12, 2022
@mui-bot
Copy link

mui-bot commented May 12, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 264.2 495.2 336 347.06 84.496
Sort 100k rows ms 446.3 910.9 774 725.58 158.121
Select 100k rows ms 102.5 218.3 196.8 171.88 46.457
Deselect 100k rows ms 111 189.9 154 154.78 30.938

Generated by 🚫 dangerJS against b6eb663

@flaviendelangle flaviendelangle changed the title [pickers] Add slots for toolbar components [pickers] Add class slots for toolbar components May 12, 2022
m4theushw
m4theushw approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flaviendelangle flaviendelangle merged commit 0a0235b into mui:master May 16, 2022
@flaviendelangle flaviendelangle deleted the slot-toolbat branch May 16, 2022 07:00
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[pickers] Add slots for toolbar components (mui#4855)
05a65cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @m4theushw