-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Keep columns section expanded when switching between pages #4816
[docs] Keep columns section expanded when switching between pages #4816
Conversation
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flaviendelangle also opened #4811 fixing this. I leave for both of you to decide who gets credit in the CHANGELOG, although the solution here is smart. I didn't realize we could test only part of the path.
I did not know about the path either We should probably add examples in the interface on the core. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
59dc516
to
89f1cb0
Compare
We don't use I'll update the description and make sure |
I tried to use it but I had a problem and was to lazy to fix it 😆 |
Yeah, it needs to be addressed in core repo, I've created a PR: mui/material-ui#32715 UPDATE: |
Quick followup on #4600
Before:
Screen.Recording.2022-05-09.at.19.48.58.mov
After:
Screen.Recording.2022-05-09.at.19.49.33.mov