Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Keep columns section expanded when switching between pages #4816

Merged
merged 1 commit into from
May 10, 2022

Conversation

cherniavskii
Copy link
Member

Quick followup on #4600

Before:

Screen.Recording.2022-05-09.at.19.48.58.mov

After:

Screen.Recording.2022-05-09.at.19.49.33.mov

@mui-bot
Copy link

mui-bot commented May 9, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 247.3 531.7 329.7 358.72 96.576
Sort 100k rows ms 460.5 869.6 722.9 670.14 143.233
Select 100k rows ms 153 194.8 186.3 177.66 17.258
Deselect 100k rows ms 108.8 197.5 193.3 169.9 33.983

Generated by 🚫 dangerJS against 89f1cb0

Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaviendelangle also opened #4811 fixing this. I leave for both of you to decide who gets credit in the CHANGELOG, although the solution here is smart. I didn't realize we could test only part of the path.

@m4theushw m4theushw added the docs Improvements or additions to the documentation label May 9, 2022
@flaviendelangle
Copy link
Member

I did not know about the path either
I already merged my PR but feel free to replace with this one if you want.

We should probably add examples in the interface on the core.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 10, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cherniavskii cherniavskii force-pushed the keep-columns-section-expanded branch from 59dc516 to 89f1cb0 Compare May 10, 2022 09:03
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 10, 2022
@cherniavskii
Copy link
Member Author

We don't use MuiPage type right now, so we don't see JSDoc from core: /~https://github.com/mui/material-ui/blob/4eef029981b08c77a9c52d0b863e6b5ced279087/docs/src/pages.ts#L17-L20

I'll update the description and make sure MuiPage is used in our repo

@cherniavskii cherniavskii merged commit ddcf17c into mui:master May 10, 2022
@cherniavskii cherniavskii deleted the keep-columns-section-expanded branch May 10, 2022 12:27
@flaviendelangle
Copy link
Member

We don't use MuiPage type right now, so we don't see JSDoc from core:

I tried to use it but I had a problem and was to lazy to fix it 😆
But yes we should

@cherniavskii
Copy link
Member Author

cherniavskii commented May 10, 2022

Yeah, it needs to be addressed in core repo, I've created a PR: mui/material-ui#32715

UPDATE: MuiPage type is now used in MUI X mui/mui-x@a52d3cd (#4854)

alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants