Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Drop allowSameDateSelection prop #4808

Merged

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 9, 2022

Fixes #4456
Fixes #4727
Part of #4728

Now that we don't fire onChange when the new value is equal to the old one, I don't see any reason to keep this prop.

Behavior

If we click on the current date, it validate just like another date
It will never call onClose since the value did not change since the last value update
It will only call onAccept if another view value has changed

What's next ?

I will prepare a follow up PR to implement mui/material-ui-pickers#1759 (comment)

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels May 9, 2022
@flaviendelangle flaviendelangle self-assigned this May 9, 2022
@mui-bot
Copy link

mui-bot commented May 9, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 239 506.9 349.1 369.02 116.759
Sort 100k rows ms 437.5 967.1 759.8 742.16 188.525
Select 100k rows ms 131.2 199.6 199.4 179.08 27.285
Deselect 100k rows ms 110 133.8 128.9 125.7 8.197

Generated by 🚫 dangerJS against 168d4d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
3 participants