[pickers] Drop allowSameDateSelection
prop
#4808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4456
Fixes #4727
Part of #4728
Now that we don't fire
onChange
when the new value is equal to the old one, I don't see any reason to keep this prop.DateTimePicker
it is set totrue
(equivalent to not having it)DatePicker
it is set tofalse
and it causes the bug of [DatePicker] Date Picker value cannot be set when changing only the year #4456DateRangePicker
it is not usedTimePicker
it is not usedBehavior
If we click on the current date, it validate just like another date
It will never call
onClose
since the value did not change since the last value updateIt will only call
onAccept
if another view value has changedWhat's next ?
I will prepare a follow up PR to implement mui/material-ui-pickers#1759 (comment)