Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateRangePicker] Refacto tests #4745

Merged
merged 1 commit into from
May 4, 2022
Merged

[DateRangePicker] Refacto tests #4745

merged 1 commit into from
May 4, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 3, 2022 •
edited
Loading

  • Use WrappedDesktopDateRangePicker for all tests
  • Rename tests should xxxx
  • Remove duplicates
  • Organize tests inside describes
  • Name spy functions handleXXX not onXXXSpy

@flaviendelangle flaviendelangle added test core Infrastructure work going on behind the scenes component: pickers This is the name of the generic UI component, not the React module! component: DateRangePicker The React component. labels May 3, 2022
@flaviendelangle flaviendelangle self-assigned this May 3, 2022
@mui-bot
Copy link

mui-bot commented May 3, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 293.4 575.2 466.7 439.34 97.064
Sort 100k rows ms 534.8 944.7 903.5 798.42 158.205
Select 100k rows ms 180.3 222.8 208.5 205.3 15.848
Deselect 100k rows ms 123.5 369.5 204.3 220.86 93.36

Generated by 🚫 dangerJS against 6304393

@flaviendelangle
Copy link
Member Author

Merging this one to lower the amount of review to be done

@flaviendelangle flaviendelangle merged commit 8684712 into mui:master May 4, 2022
@flaviendelangle flaviendelangle deleted the date-range-refacto branch May 4, 2022 12:23
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[DateRangePicker] Refacto tests (mui#4745)
131ec9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@flaviendelangle flaviendelangle

Labels
component: DateRangePicker The React component. component: pickers This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaviendelangle @mui-bot