Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Enable mask by default when using ampm=true #4731

Merged
merged 1 commit into from
May 4, 2022

Conversation

alexfauquette
Copy link
Member

Fix #4488

The default value of disableMaskedInput was set to true if the component used ampm=true

This sounds like it has been partially fixed because acceptRegex and inputFormat were adapted to accept meridian time. Only the mask was not adapted. Now it's done and tested

@mui-bot
Copy link

mui-bot commented May 2, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 259.2 684.3 403.2 425.76 159.346
Sort 100k rows ms 472.4 1,013.5 696.3 801.72 194.989
Select 100k rows ms 124.6 271 219.9 200.36 63.614
Deselect 100k rows ms 108.5 213.7 199.5 185.78 39.346

Generated by 🚫 dangerJS against 3ab02ab

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected

@alexfauquette alexfauquette merged commit 1ff403d into mui:master May 4, 2022
@alexfauquette alexfauquette deleted the allows-masks branch May 4, 2022 11:45
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TimePicker] "Mask" prop on TimePicker doesn't seem to do anything
4 participants