[MonthPicker] New prop shouldDisableMonth
#4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
someone635
changed the title
someone635
force-pushed
the
add_shouldDisableMonth
branch
from
37c0a58 to
73bf514
Compare
flaviendelangle
added
the
component: pickers
flaviendelangle
changed the title
shouldDisableMonth
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
|
Suggested review changes implemented |
flaviendelangle
approved these changes
May 6, 2022
| * @param {TDate} month The new year. | ||
| * @returns {void|Promise} - | ||
| */ | ||
| onMonthChange?: (month: TDate) => void | Promise<void>; |
There was a problem hiding this comment.
Not related to this PR but onMonthChange can return a promise and not onYearChange, the typing feels wrong.
I will have a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening here a PR I opened previously on @mui/lab
Took the liberty to add this small functionality, as I needed it in my project. I wonder if there was a rationale behind having shouldDisableYear and not shouldDisableMonth.
Use case: I want users to select editions of a monthly magazine, yet the magazine isn't systematically published every month.
The shouldDisableMonth has exactly the same functionality as shouldDisableYear, it disables the month only on the "month" view. It is still possible to access dates of that month using the "day" view and using arrows, so it may have to be combined with shouldDisableDate for 100% disabling.