[DataGrid] Update focused action if the currently focused one is removed #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
These are the results for the performance tests:
|
m4theushw
commented
Apr 29, 2022
| @@ -102,24 +102,20 @@ export default function FullFeaturedCrudGrid() { | |||
| event.defaultMuiPrevented = true; | |||
| }; | |||
|
|
|||
| const handleEditClick = (id) => (event) => { | |||
| event.stopPropagation(); | |||
There was a problem hiding this comment.
Any event.stopPropagation() call prevents the grid from updating the internal state.
m4theushw
added
bug 🐛
Comment on lines
72
to
75
| if (focusedButtonIndex >= numberOfChildren) { | ||
| setFocusedButtonIndex(numberOfChildren - 1); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I don't get why you have this correction of focusedButtonIndex compared to numberOfChildren, and in another useEffect you do a similar check with numberOfButtons.
Maybe one correction with either numberOfChildren or numberOfButtons is enought
There was a problem hiding this comment.
I removed setFocusedButtonIndex from the code highlighted. There's another effect that updates the state.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
alexfauquette
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4675
When I did #4325 I didn't realize that the number of actions could change and the index storing which button has focus should be updated. This PR is fixing this by checking if the index is greater than the number of actions, if true put focus on the last button.