-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Add overrides to PickersArrowSwitcher
#4672
Conversation
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem to match with what we do on the rest of the codebase, especially in Material UI.
Some components have "private" class names. Do you agree to make them public? In the DataGrid every new class is public.
Usually, developers ask to be able to customize everything. I think that the only cases when a class name should stay private is if we don't envison a way to use it for customization, or if either is a better way to achieve the same customization.
Or if we want to be able to change them before the next major |
I would say to keep only classes of the |
Preview: https://deploy-preview-4672--material-ui-x.netlify.app/x/react-date-pickers/date-picker/
An example for #4669
My goal was to only restore the capability to provide overrides via the theme and add meaningful class names. I didn't add the
classes
prop.Some components have "private" class names. Do you agree to make them public? In the DataGrid every new class is public.
mui-x/packages/x-date-pickers/src/CalendarPicker/PickersSlideTransition.tsx
Line 18 in 0d8a55d
Before:
After: