[docs] Add plan in the nav bar for pro-only and premium-only pages #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
commented
Apr 21, 2022
| @@ -86,7 +88,7 @@ const pages = [ | |||
| { pathname: '/x/react-date-pickers/time-picker' }, | |||
| { | |||
| pathname: '/x/api/date-pickers', | |||
| title: ' • API Reference', | |||
| title: 'API Reference', | |||
There was a problem hiding this comment.
I prefer without it but I can add it back if you want
| @@ -256,7 +255,7 @@ function AppWrapper(props) { | |||
| <PageContext.Provider value={{ activePage, pages: productPages }}> | |||
| <ThemeProvider> | |||
| <DocsStyledEngineProvider cacheLtr={emotionCache}> | |||
| <XWrapper>{children}</XWrapper> | |||
| {children} | |||
There was a problem hiding this comment.
The pro / premium icon CSS is now defined on the core
|
These are the results for the performance tests:
|
12 tasks
m4theushw
approved these changes
Apr 21, 2022
|
We have an issue with the side nav. On https://master--material-ui-x.netlify.app/x/react-data-grid/tree-data/ the navigation is closed Actual
Expected
The current expand/collapse logic relies on the URL prefixed structured. |
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4581
Preview: https://deploy-preview-4591--material-ui-x.netlify.app/x/react-data-grid/