-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Add explicit interfaces for components slots and components slots props #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the results for the performance tests:
|
flaviendelangle
commented
Apr 21, 2022
|
||
const releaseInfo = getReleaseInfo(); | ||
|
||
interface BaseDateRangePickerProps<TDate> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This interface was a copy paste of the one in DateRangePicker/shared
flaviendelangle
added
the
component: pickers
This is the name of the generic UI component, not the React module!
label
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4466
Goal
Clean the typing of the
components
andcomponentsProps
props before expanding the usage of the pattern in future PRs.The
XXXSlotsComponent
andXXXSlotsComponentsProps
are not nullable, it is theXXXProps
interface which has aPartial
(like on the DataGrid)If the
components
orcomponentsProps
is defined in one of the interface extended by the current component AND this interface is not tightly linked to the new component, then redefine explicitlycomponents
andcomponentsProps
(ie: do not redefine onDesktopDatePickerProps
if defined onBaseDatePickerProps
, but redefine onCalendarPickerProps
if defined onPickersCalendarHeader
)What's next ?
components
and therecomponentsProps
componentsProps
for each existingcomponents
like on the DataGridprops.XXXXProps
andprops.XXXXComponent
(PopperProps
,TransitionComponent
, ...) to the slot pattern