Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Enforce noImplicitAny for docs folder #4412

Merged
merged 12 commits into from
Apr 13, 2022
Merged

[core] Enforce noImplicitAny for docs folder #4412

merged 12 commits into from
Apr 13, 2022

Conversation

cherniavskii
Copy link
Member

Follow up on #4084
Part of #479

@mui-bot
Copy link

mui-bot commented Apr 8, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 238.7 432.7 307.6 324.32 79.623
Sort 100k rows ms 451.8 934.2 719.5 690.5 174.059
Select 100k rows ms 87.2 201.7 187.7 164.18 40.036
Deselect 100k rows ms 91.3 207.1 185 144.76 43.764

Generated by 🚫 dangerJS against 638d905

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes typescript labels Apr 8, 2022
@cherniavskii cherniavskii marked this pull request as ready for review April 11, 2022 17:13
alexfauquette
alexfauquette approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean 👍

docs/data/data-grid/filtering/CustomFilterPanelContent.js Outdated Show resolved Hide resolved
flaviendelangle
flaviendelangle approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge, I'll add it to the release

@cherniavskii cherniavskii merged commit 33c5338 into mui:master Apr 13, 2022
@cherniavskii cherniavskii deleted the no-implicit-any-continuation branch April 13, 2022 12:34
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@cherniavskii @alexfauquette
[core] Enforce noImplicitAny for docs folder (mui#4412)
307208f
@cherniavskii cherniavskii mentioned this pull request Aug 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cherniavskii @mui-bot @flaviendelangle @alexfauquette @oliviertassinari