Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Add react-dom to pickers peer deps to satisfy react-transition-group #4411

Merged
merged 1 commit into from
Apr 11, 2022
Merged

[pickers] Add react-dom to pickers peer deps to satisfy react-transition-group #4411

merged 1 commit into from
Apr 11, 2022

Conversation

CarsonF
Copy link
Contributor

@CarsonF CarsonF commented Apr 8, 2022 •
edited
Loading 

$ yarn explain peer-requirements pe404c
➤ YN0000: @mui/x-date-pickers@npm:5.0.0-alpha.0 [b95f3] doesn't provide react-dom, breaking the following requirements:

➤ YN0000: react-transition-group@npm:4.4.2 [419ef] → >=16.6.0 ✘

@mui-bot
Copy link

mui-bot commented Apr 8, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 242.1 489.3 323.9 343.3 90.96
Sort 100k rows ms 451 852.7 710.7 686.32 131.735
Select 100k rows ms 99.7 211.8 205.4 166.04 46.333
Deselect 100k rows ms 105.8 224.6 136.4 161.5 50.092

Generated by 🚫 dangerJS against 7bef825

@flaviendelangle flaviendelangle changed the title Add react-dom to pickers peer deps to satisfy react-transition-group [pickers] Add react-dom to pickers peer deps to satisfy react-transition-group Apr 11, 2022
@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Apr 11, 2022
@flaviendelangle flaviendelangle merged commit d4c1080 into mui:master Apr 11, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@CarsonF @alexfauquette
Add react-dom to pickers peer deps to satisfy react-transition-group (m…
1e885f2 
…ui#4411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarsonF @mui-bot @flaviendelangle