Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix api prop leaking to DOM #4384

Merged
merged 1 commit into from
Apr 11, 2022
Merged

[DataGrid] Fix api prop leaking to DOM #4384

merged 1 commit into from
Apr 11, 2022

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Apr 6, 2022 •
edited
Loading

Fixes

image

Screenshot taken from https://mui.com/components/data-grid/demo/

@mui-bot
Copy link

mui-bot commented Apr 6, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 267.4 551.6 460.6 431.8 94.567
Sort 100k rows ms 662.9 1,103.4 721.6 834.82 169.522
Select 100k rows ms 121.9 212.3 192.8 171.04 39.716
Deselect 100k rows ms 154.5 238.2 192.2 191.02 28.231

Generated by 🚫 dangerJS against df64d2f

@m4theushw m4theushw self-assigned this Apr 8, 2022
@m4theushw m4theushw merged commit c14664f into mui:master Apr 11, 2022
@m4theushw m4theushw deleted the api-prop-leaking branch April 11, 2022 15:43
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@m4theushw @alexfauquette
[DataGrid] Fix api prop leaking to DOM (mui#4384)
9a215f9
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees

@m4theushw m4theushw

Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m4theushw @mui-bot @flaviendelangle @oliviertassinari