Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Adjust type of GridColumnHeaderTitle description prop #4247

Conversation

baahrens
Copy link

As this gets passed to Tooltips title prop, it should match the type I believe.

ref: /~https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Tooltip/Tooltip.d.ts#L165

@mui-bot
Copy link

mui-bot commented Mar 21, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 270.9 678.9 521.2 476.4 173.983
Sort 100k rows ms 503.3 1,145.7 503.3 845.62 238.721
Select 100k rows ms 162.1 255.5 201.4 209.44 35.826
Deselect 100k rows ms 112.7 275.5 201.4 210.4 58.593

Generated by 🚫 dangerJS against 70e5227

@flaviendelangle
Copy link
Member

Thanks for your contribution !

@flaviendelangle flaviendelangle added the component: data grid This is the name of the generic UI component, not the React module! label Mar 22, 2022
@m4theushw
Copy link
Member

This one can be included in the next release.

@flaviendelangle flaviendelangle merged commit 8044100 into mui:master Mar 24, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants