Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add CLI to decode license key #4126

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Mar 8, 2022

@mbrookes, with this you would be able to do:

npm i -g @mui/x-license-pro
npx licensedecode -k xxx

I took the same naming strategy as licensegen but in a 2nd version I would like to correctly namespace the commands and do:

npx mui-license gen -o xxx
npx mui-license decode -k xxx

@flaviendelangle flaviendelangle self-assigned this Mar 8, 2022
@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Mar 8, 2022
@mui-bot
Copy link

mui-bot commented Mar 8, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 223.5 418.5 307.5 302.46 71.627
Sort 100k rows ms 442.6 898.4 624.1 627.06 164.442
Select 100k rows ms 144.1 278.6 233.1 226.44 50.722
Deselect 100k rows ms 99.2 295.7 262.9 190.32 77.902

Generated by 🚫 dangerJS against 2e960b1

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@flaviendelangle flaviendelangle merged commit f6ccf75 into mui:master Mar 14, 2022
@flaviendelangle flaviendelangle deleted the cli-license-decode branch March 14, 2022 09:05
@oliviertassinari oliviertassinari added the package: x-license Specific to @mui/x-license. label Mar 22, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 23, 2022

In the long run, I wonder if we shouldn't progressively move from CLI to custom UIs built with our low-code product cc @mui/toolpad. CLIs are great but they are as useful as they can be discovered. If we have a page that lists all the CLI, we might want to make it interactive, directly, skipping the need to install and run the scripts 🤔.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes package: x-license Specific to @mui/x-license.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants