Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Avoid crash in demos using row grouping and custom formatted cells #4065

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Mar 1, 2022

  1. Open https://master--material-ui-x.netlify.app/components/data-grid/group-pivot/#full-example
  2. Scroll all the way to the right
  3. 💥

I noticed while reviewing #4030

A better solution would be to not render the cells in auto-generated rows, but we have the problem where we need to call getCellParams to pass to cellClassName which calls the value formatter.

@m4theushw m4theushw changed the title [docs] Avoid crash when grouping rows from the commodity dataset [docs] Avoid crash in demos using row grouping and custom formatted cells Mar 1, 2022
@m4theushw m4theushw added the docs Improvements or additions to the documentation label Mar 1, 2022
@mui-bot
Copy link

mui-bot commented Mar 1, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 225 391.6 369.8 317.6 75.42
Sort 100k rows ms 384.8 895.3 708.6 648.2 178.706
Select 100k rows ms 155.3 304.7 182.5 202.78 54.368
Deselect 100k rows ms 90.2 275.4 139.4 155.06 62.852

Generated by 🚫 dangerJS against c1a6999

@flaviendelangle
Copy link
Member

flaviendelangle commented Mar 2, 2022

A better solution would be to not render the cells in auto-generated rows

In some scenarios, rendering those cells can be useful.
But I agree that we could improve how it works.

I am also fixing it in /~https://github.com/mui/mui-x/pull/4064/files#diff-8dad26ca77285751ab928cda82ebfe0d7d6e97863d735aadf17a633a8bd72f76R248.

@m4theushw m4theushw merged commit cc985bb into mui:master Mar 2, 2022
@m4theushw m4theushw deleted the value-can-be-null branch March 2, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants