Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Always update renderZone when modifying the renderContext #4058

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Feb 28, 2022

Fix #3890

@mui-bot
Copy link

mui-bot commented Feb 28, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 241.6 476.2 343 341.76 87.069
Sort 100k rows ms 502.8 840.2 657.6 677.72 110.558
Select 100k rows ms 140.2 261.7 193.7 199.06 39.181
Deselect 100k rows ms 128.4 194.6 177 168.92 25.947

Generated by 🚫 dangerJS against 76cb653

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 1, 2022
@alexfauquette alexfauquette marked this pull request as ready for review March 1, 2022 15:18
@alexfauquette
Copy link
Member Author

This bug is quite hard to reproduce. I'm not sure we can add a test on this one

@alexfauquette alexfauquette requested a review from m4theushw March 1, 2022 16:49
@alexfauquette alexfauquette self-assigned this Mar 2, 2022
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug is quite hard to reproduce. I'm not sure we can add a test on this one

If you want to test it, you could check if the render zone is correctly repositioned after scrolling to the right and sorting a column. It could also be tested adding a regression test. All these tests are based on making an action which will cause the dependencies below to change. Once they change, the effect runs and updates the context, but on HEAD it doesn't update the render zone as it should.

disableVirtualization,
rowsMeta.positions,
rootProps.autoHeight,
currentPage.rows.length,
columnPositions,
containerWidth,
visibleColumns.length,

@m4theushw m4theushw changed the title Allways update renderZone when modifying the renderContext [DataGrid] Always update renderZone when modifying the renderContext Mar 2, 2022
@flaviendelangle
Copy link
Member

Can we merge this one before releasing v5.6 ?

@alexfauquette alexfauquette merged commit fa60130 into mui:master Mar 3, 2022
@alexfauquette alexfauquette deleted the sync-rows-header branch March 3, 2022 10:13
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Sorting in a DataGrid with many columns can shift rows in relation to the column headers
5 participants