-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Always update renderZone when modifying the renderContext #4058
Conversation
These are the results for the performance tests:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This bug is quite hard to reproduce. I'm not sure we can add a test on this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug is quite hard to reproduce. I'm not sure we can add a test on this one
If you want to test it, you could check if the render zone is correctly repositioned after scrolling to the right and sorting a column. It could also be tested adding a regression test. All these tests are based on making an action which will cause the dependencies below to change. Once they change, the effect runs and updates the context, but on HEAD it doesn't update the render zone as it should.
mui-x/packages/grid/x-data-grid/src/hooks/features/virtualization/useGridVirtualScroller.tsx
Lines 113 to 119 in ea260ca
disableVirtualization, | |
rowsMeta.positions, | |
rootProps.autoHeight, | |
currentPage.rows.length, | |
columnPositions, | |
containerWidth, | |
visibleColumns.length, |
Can we merge this one before releasing v5.6 ? |
Fix #3890