Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Disable export for detail panel column #4057

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

gustavhagland
Copy link
Contributor

Currently, export a table with detailed panels exports a column with name:
__detail_panel_toggle__and only values: true or false indicating the state.

These are not usefull values and should be disabled by default

@mui-bot
Copy link

mui-bot commented Feb 28, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 245.9 504.4 390 377.84 90.131
Sort 100k rows ms 663.6 912.2 788.9 786.98 104.155
Select 100k rows ms 257.5 369.8 286.1 297.32 37.941
Deselect 100k rows ms 173.4 314.2 217.8 244.36 55.164

Generated by 🚫 dangerJS against 8d8f57e

@m4theushw m4theushw changed the title Disable export for detail panel column [DataGridPro] Disable export for detail panel column Feb 28, 2022
@m4theushw m4theushw added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request labels Feb 28, 2022
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m4theushw m4theushw merged commit a6f445d into mui:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants