[DataGrid] Use buildWarning and wrapWithWarningOnCall for deprecated methods and wrong usages
#4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods and wrong usages
flaviendelangle
added
the
component: data grid
|
These are the results for the performance tests:
|
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
flaviendelangle
commented
Mar 1, 2022
| @@ -18,8 +18,8 @@ export const buildWarning = ( | |||
| }; | |||
| }; | |||
|
|
|||
| export const wrapWithWarningOnCall = <Args extends any[], R extends any>( | |||
| method: (...args: Args) => R, | |||
| export const wrapWithWarningOnCall = <F extends Function>( | |||
There was a problem hiding this comment.
This change is here to support selectors which have a type of the form OutputSelector<S, R> | (state: S) => R
alexfauquette
approved these changes
Mar 3, 2022
packages/grid/x-data-grid/src/hooks/features/rows/useGridParamsApi.ts
Outdated
Show resolved
Hide resolved
…sApi.ts Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.