[DataGrid] Remove last filter item when no value to clean and close the filter panel #3910
Conversation
|
These are the results for the performance tests:
|
| if (item.value === undefined) { | ||
| deleteFilter(item); | ||
| } else { | ||
| // TODO v6: simplify the behavior by always removing the filter form |
There was a problem hiding this comment.
| // TODO v6: simplify the behavior by always removing the filter form | |
| // TODO v6: simplify the behavior by always remove the filter form |
alexfauquette
force-pushed
the
cleanFilterPanel
branch
from
7c88838 to
37ac59c
Compare
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
alexfauquette
added
component: data grid
| @@ -243,7 +243,12 @@ function GridFilterForm(props: GridFilterFormProps) { | |||
|
|
|||
| const handleDeleteFilter = () => { | |||
| if (rootProps.disableMultipleColumnsFiltering) { | |||
| applyFilterChanges({ ...item, value: undefined }); | |||
| if (item.value === undefined) { | |||
There was a problem hiding this comment.
Note that it only deletes the last item when clicking twice. In a string column, the empty input means item.value="" which falls into the else branch.
There was a problem hiding this comment.
And I assume the isAnyOf after being cleaned is an empty array, so we have two more cases to check, but we can not use !item.value due to boolean filters
| apiRef.current.deleteFilterItem(item); | ||
| if (shouldCloseFilterPanel) { | ||
| apiRef.current.hideFilterPanel(); |
There was a problem hiding this comment.
If the developer is controlling the filter items through the filterModel prop we don't know if he accept the new value passed via onFilterModelChange. In this case we can't assume that when hideFilterPanel is called it will have 0 filter items. I had the same problem with the editRowsModel prop triggering synchronous actions after changing the prop value.
There was a problem hiding this comment.
I forget it was controllable. We could track items.length and close the pannel when reaching 0
Fix #3841
It modifies the behavior of the filter pannel by closing it when deleting the last item. But I see that as an improvement instead of a breaking change