[docs] Fix inline previews #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
requested review from
oliviertassinari,
flaviendelangle,
eps1lon,
m4theushw and
alexfauquette
eps1lon
approved these changes
Nov 3, 2021
| @@ -13,8 +13,8 @@ | |||
| "export": "rimraf docs/export && next export --threads=3 -o export && yarn build-sw", | |||
| "icons": "rimraf public/static/icons/* && node ./scripts/buildIcons.js", | |||
| "typescript": "tsc -p tsconfig.json", | |||
| "typescript:transpile": "node scripts/formattedTSDemos", | |||
| "typescript:transpile:dev": "node scripts/formattedTSDemos --watch" | |||
| "typescript:transpile": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" scripts/formattedTSDemos", | |||
There was a problem hiding this comment.
Why do you need to switch to babel-node here? I would recommend to stick to just node until it becomes absolutely necessary.
There was a problem hiding this comment.
If I leave it as it was the script fails. I checked how it's done in the core and copied the approach.
alexfauquette
approved these changes
Nov 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2990
Based on mui/material-ui#28215
The diff is so big because the previews need to be generated.
Preview -> https://deploy-preview-3081--material-ui-x.netlify.app/components/data-grid/columns/#column-definitions