Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use selectors instead of direct state access in feature hooks and components #2723

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 28, 2021

Extracted from #2572

Breaking changes

I renamed 2 selectors and 2 types to match to naming structure of the Grid.
More are to be renamed in #2572 and in the tree data PR but it would cause git conflicts to rename them here.

-const filterModel = filterGridStateSelector(state);
+const filterModel = gridFilterModelSelector(state);
-const density: GridGridDensity = densitySelector(state);
+const density: GridDensityState = gridDensitySelector(state);
-const rendering: InternalRenderingState = gridRenderingSelector(state);
+const rendering: GridRenderingState = gridRenderingSelector(state);

@flaviendelangle flaviendelangle self-assigned this Sep 28, 2021
@flaviendelangle flaviendelangle added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Sep 29, 2021
@flaviendelangle
Copy link
Member Author

I will merge this PR tomorrow morning if no review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant