-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve the feedback loop from developers #2468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
support-paid-plans
branch
from
August 28, 2021 22:27
643eef5
to
a5b5756
Compare
mbrookes
requested changes
Aug 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only suggested changes once for duplicate strings.
mbrookes
previously requested changes
Aug 29, 2021
mbrookes
approved these changes
Aug 29, 2021
This was referenced Aug 29, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request started out of my frustration of having developers send emails to get support on the Pro plan. This feels inefficient because:
Instead, by moving the questions to GitHub, we can for instance: link duplicates, link PRs that are fixing the root causes. A note on StackOverflow. This is a pain we have with it too, the main difference is that the community is answering these support questions. It's a tradeoff we have made to leverage the gamification they have in place to incentive contributions. With the Pro plan, it's us that have to answer, I doubt that the community will have the incentive to contribute much.
But while I was working on it, I realized that GitHub had a neat new feature in beta: Issue forms. I went on leveraging it.
You can preview the exact impacts of these changes at /~https://github.com/mui-org/test-issue-template/issues/new/choose. For instance:
The aim is to backport these changes into @mui-org/core if the PR is merged.