Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fire columnOrderChange event after state update #2451

Merged
merged 3 commits into from
Aug 27, 2021
Merged

[DataGrid] Fire columnOrderChange event after state update #2451

merged 3 commits into from
Aug 27, 2021

Conversation

flaviendelangle
Copy link
Member

Closes #2449

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Aug 25, 2021
@flaviendelangle flaviendelangle self-assigned this Aug 25, 2021
@flaviendelangle flaviendelangle requested review from m4theushw, dtassone and DanailH and removed request for m4theushw August 26, 2021 09:48
m4theushw
m4theushw reviewed Aug 26, 2021
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case to ensure that this prop is called after reordering a column?

@flaviendelangle
Copy link
Member Author

@m4theushw Done

@flaviendelangle @m4theushw
Update packages/grid/x-grid/src/tests/reorder.DataGridPro.test.tsx
dc3bf57 
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
@flaviendelangle flaviendelangle merged commit 1a28366 into mui:next Aug 27, 2021
@flaviendelangle flaviendelangle deleted the columnOrderChange branch August 27, 2021 17:20
@flaviendelangle flaviendelangle mentioned this pull request Nov 18, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@dtassone dtassone Awaiting requested review from dtassone

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column state not up to date when onColumnOrderChange is fired
2 participants
@flaviendelangle @m4theushw